Log Group Parsing bug in awsxrayexporter #13702
Assignees
Labels
Comments
felixscheinost
added a commit
to felixscheinost/opentelemetry-java
that referenced
this issue
Aug 30, 2022
Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702) So remove addition of the trailing `:*` for now.
felixscheinost
added a commit
to felixscheinost/opentelemetry-java
that referenced
this issue
Aug 30, 2022
Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702) So remove addition of the trailing `:*` for now.
|
Pinging code owners: @willarmiros. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
jack-berg
pushed a commit
to open-telemetry/opentelemetry-java
that referenced
this issue
Sep 8, 2022
* Improve detection of resource attributes on ECS This improves the detection of resource attributes on ECS by fetching ECS metadata from `ECS_CONTAINER_METADATA_URI` or `ECS_CONTAINER_METADATA_URI_V4`. Previously only `CONTAINER_NAME` and `CONTAINER_ID` id were set. Now we set: - CONTAINER_ID - CONTAINER_NAME - AWS_ECS_CONTAINER_ARN - CONTAINER_IMAGE_NAME - CONTAINER_IMAGE_TAG - aws.ecs.container.image.id - AWS_LOG_GROUP_ARNS - AWS_LOG_GROUP_NAMES - AWS_LOG_STREAM_NAMES - AWS_ECS_TASK_ARN - AWS_ECS_TASK_FAMILY - AWS_ECS_TASK_REVISION Especially AWS_LOG_GROUP_ARNS is important so that connection of traces to logs works OOTB on X-Ray. * Change „24“ to „26“ in fixtures for consistency `CONTAINER_NAME` and `AWS_ECS_TASK_REVISION` should match * Implement a few more attributes, fix ARNs This commit adds implementations for the `aws.ecs.launchtype` and `aws.logs.stream.arns` attributes, as well as fixing the generation of log group ARNs. * EcsResource: Record log group without trailing :* Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702) So remove addition of the trailing `:*` for now. Co-authored-by: Michele Mancioppi <michelem@lumigo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In the official AWS Docs, there are two valid forms of a CloudWatch Log group ARN. Today, the log group ARN parser only treats the first (without a trailing
:*) as valid, but it should be able to handle both.Steps to reproduce
Attempt to translate a log group ARN with a trailing
:*What did you expect to see?
Correct Log group name
What did you see instead?
*as the log group nameAdditional context
See open-telemetry/opentelemetry-java#4574
cc @felixscheinost @mmanciop
The text was updated successfully, but these errors were encountered: