-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin GitHub Actions macos runner version and build for darwin/amd64 #6721
Merged
ashutosh-narkar
merged 5 commits into
open-policy-agent:main
from
suzuki-shunsuke:chore-build-darwin-amd64
Apr 26, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5f60e01
ci: pin GitHub Actions macos runner version and build for darwin/amd64
suzuki-shunsuke 90f8b0a
ci: skip building darwin/arm64 non static binary
suzuki-shunsuke 0c12f07
ci: pin GitHub Actions macos runner version
suzuki-shunsuke 9914a2a
ci: test opa_darwin_arm64_static too
suzuki-shunsuke af741a6
ci: disable wasm for opa_darwin_arm64_static
suzuki-shunsuke File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPU architecture of macos-13 is amd64.
Should we test opa_darwin_arm64_static too?
opa/.github/workflows/pull-request.yaml
Line 268 in f76246f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if we were consistent with the macos version. If we just used
macos-13
then we don't need to change anything else.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test opa_darwin_amd64, we have to use macos-13.
And to test test opa_darwin_arm64_static, we have to use macos-14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test of opa_darwin_arm64_static.
f41eccd
This means to run smoke test of both opa_darwin_amd64 and opa_darwin_arm64_static.