refactor: use generics for ADT #6705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
|
@nikpivkin thanks for the contribution. I would encourage you to first create an issue and explain the proposal. Mainly the problem it's trying to solve and the improvements. This would give others a chance to chime in as well. A quick look at the PR shows there are API changes that are not backwards compatible. We generally attempt to maintain backwards compatibility. So feel free to open an issue first and the community can discuss there. Thanks. |
|
Closing this for now. Feel free to open an issue to discuss the proposal. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
What are the changes in this PR?
Notes to assist PR review:
Further comments: