Commits on Dec 12, 2022

1. providers/aws: Refactor + Fix 2x Authorization header append issue. …

   This commit refactors the shared AWS Sig v4 signing code, specifically
   to prevent the issue behind open-policy-agent#5472. The underlying problem for open-policy-agent#5472 was
   that the `"Authorization"` header was being appended *twice* to the
   request, but only for the AWS REST plugin, because the value was pulled
   twice from the signed headers map.
   
   This was not caught by the unit tests, because the REST plugin's unit
   tests all assumed the header was single-valued and canonicalized.
   
   We now explicitly test for that condition in the unit tests, and the
   signing code now returns the AWS headers map separately from the value
   for the `"Authorization"` header, reducing the potential for this
   mistake to happen in the future.
   
   Fixes: open-policy-agent#5472
   
   Signed-off-by: Philip Conrad <philipaconrad@gmail.com>

   

   philipaconrad committed Dec 12, 2022
   Copy the full SHA

   d514932 View commit details

   Browse the repository at this point in the history