Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opa build -t wasm|plan: fail on unmatched entrypoints #5086

Merged

Conversation

anderseknert
Copy link
Member

Fixes #3957

Signed-off-by: Anders Eknert anders@eknert.com

compile/compile.go Outdated Show resolved Hide resolved
compile/compile.go Outdated Show resolved Hide resolved
compile/compile.go Outdated Show resolved Hide resolved
srenatus
srenatus previously approved these changes Sep 6, 2022
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, one nitpick, This looks good, thanks!

compile/compile_test.go Show resolved Hide resolved
compile/compile.go Outdated Show resolved Hide resolved
compile/compile.go Outdated Show resolved Hide resolved
srenatus
srenatus previously approved these changes Sep 7, 2022
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Fixes open-policy-agent#3957

Signed-off-by: Anders Eknert <anders@eknert.com>
Signed-off-by: Anders Eknert <anders@eknert.com>
@anderseknert anderseknert merged commit 3ed3643 into open-policy-agent:main Sep 7, 2022
@anderseknert anderseknert deleted the unmatched-entrypoints branch September 7, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opa build: deny entrypoints that don't map to module tree
3 participants