New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opa build -t wasm|plan: fail on unmatched entrypoints #5086
Merged
anderseknert
merged 2 commits into
open-policy-agent:main
from
anderseknert:unmatched-entrypoints
Sep 7, 2022
Merged
opa build -t wasm|plan: fail on unmatched entrypoints #5086
anderseknert
merged 2 commits into
open-policy-agent:main
from
anderseknert:unmatched-entrypoints
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsandall
reviewed
Sep 2, 2022
anderseknert
force-pushed
the
unmatched-entrypoints
branch
from
September 3, 2022 20:40
bdb6010
to
9cc5f80
Compare
srenatus
previously approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, one nitpick, This looks good, thanks!
anderseknert
force-pushed
the
unmatched-entrypoints
branch
from
September 6, 2022 07:45
9cc5f80
to
2db5627
Compare
anderseknert
commented
Sep 6, 2022
srenatus
reviewed
Sep 6, 2022
anderseknert
force-pushed
the
unmatched-entrypoints
branch
from
September 6, 2022 12:17
2db5627
to
4d6cbad
Compare
srenatus
previously approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes open-policy-agent#3957 Signed-off-by: Anders Eknert <anders@eknert.com>
Signed-off-by: Anders Eknert <anders@eknert.com>
anderseknert
force-pushed
the
unmatched-entrypoints
branch
from
September 7, 2022 12:31
7082357
to
17c7d6b
Compare
srenatus
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3957
Signed-off-by: Anders Eknert anders@eknert.com