cmd/build+compile: allow opt-out of dependents gathering #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
changed the title
srenatus
force-pushed
the
sr/compile/issue-5035
branch
2 times, most recently
from
e01d770
to
358eb5e
Compare
anderseknert
previously approved these changes
Aug 23, 2022
compile/compile.go
Outdated
| // | ||
| // Notably this includes functions (they can't be entrypoints) and causes | ||
| // the built bundle to no longer be semantically equivalent to the bundle built | ||
| // without wasm, or optimizations.} |
There was a problem hiding this comment.
Might be worth mentioning this option is for -t plan just as much?
There was a problem hiding this comment.
There's no real equivalence there, I thought... but yeah as it stands, the "optimizations" part is also misleading. I'll update the comment. Thanks!
With `.WithPruneUnused(true)`, the compiler (of the compile package) no longer collects dependents of its entrypoints. The resulting bundle, if used with the wasm target, will no longer be semantically equivalent to the bundle built with the rego target. Since we're unable to have entrypoints for functions, this allows building modules that we couldn't build before. See open-policy-agent#5035. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/compile/issue-5035
branch
from
358eb5e
to
af5de64
Compare
anderseknert
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
.WithPruneUnused(true), the compiler (of the compile package) no longercollects dependents of its entrypoints.
The resulting bundle, if used with the wasm target, will no longer be
semantically equivalent to the bundle built with the rego target.
Since we're unable to have entrypoints for functions, this allows building
modules that we couldn't build before.
Fixes #5035.