Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: Speed up set unions #4980

Merged
merged 6 commits into from
Aug 11, 2022
Merged

builtins: Speed up set unions #4980

merged 6 commits into from
Aug 11, 2022

Commits on Aug 11, 2022

  1. topdown/sets: Improve union performance by manual inlining. 

    Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    571f2a8 View commit details
    Browse the repository at this point in the history

  2. topdown/topdown_bench_test: Add set union benchmarks. 

    Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e85d84e View commit details
    Browse the repository at this point in the history

  3. topdown/sets: Fix confusing name shadowing. 

    The compiler correctly handled the lexical scoping here, but changing
the name makes it explicit for the humans reading that snippet as well.

Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e053777 View commit details
    Browse the repository at this point in the history

  4. topdown/sets: Foreach function cleanup. 

    Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    72b3c87 View commit details
    Browse the repository at this point in the history

  5. topdown/sets_test: Add set union regression tests. 

    Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a2ffa63 View commit details
    Browse the repository at this point in the history

  6. topdown/sets_bench_test: Move set builtin benchmarks. 

    Signed-off-by: Philip Conrad <philipaconrad@gmail.com>
    @philipaconrad
    philipaconrad committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    28e3272 View commit details
    Browse the repository at this point in the history