Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .yml files in opa bundle command #4882

Merged
merged 2 commits into from Jul 13, 2022

Conversation

Joffref
Copy link
Contributor

@Joffref Joffref commented Jul 12, 2022

This PR resolves this issue : #4859
Signed-off-by: Joffref mariusjoffre@gmail.com

Copy link
Contributor

@philipaconrad philipaconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Signed-off-by: Joffref <mariusjoffre@gmail.com>
Signed-off-by: Joffref <mariusjoffre@gmail.com>
@philipaconrad philipaconrad merged commit aa487ed into open-policy-agent:main Jul 13, 2022
@philipaconrad
Copy link
Contributor

@Joffref I manually added the Fixes #4859 bit to the squash commit so that Github will auto-close the related issue. In the future, I'd recommend adding that sort of note manually to your commit messages. 😃 Project maintainers will thank you!

Related reading: Github Docs page on PR/commit keywords

Thank you for your contribution! 👍

@Joffref
Copy link
Contributor Author

Joffref commented Jul 13, 2022

I didn't even know it exists! Thanks for your advice 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants