OCI: Fix bundle reload and activation unconditionally #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
May 4, 2022
There was a problem hiding this comment.
Code looks good -- just a test would be really nice. Also @ashutosh-narkar knows this code much better than I do, so I'll wait for him to have a look.
srenatus
reviewed
May 12, 2022
| t.Fatalf("expected true but got: %s", response) | ||
| } | ||
|
|
||
| expContains := "Bundle loaded and activated successfully" |
There was a problem hiding this comment.
Hmm perhaps we should also check that the second pull did not do this? 🤔 Maybe I'm missing something... 🔍
There was a problem hiding this comment.
Rebased and added a verification that the bundle is skipped also in the e2e OCI test if it's the same on the pooling mechanism. I had to set the log level to debug in the test as the skip message is shown only on debug mode.
srenatus
previously approved these changes
May 12, 2022
|
|
||
| time.Sleep(3 * time.Second) // wait for the downloader pooling mechanism to kick in | ||
| expContains := "Bundle loaded and activated successfully" | ||
| skipContains := "Bundle load skipped, server replied with not modified." |
There was a problem hiding this comment.
hmm. not exactly on-point, but fair enough 🤔
|
Could you please rebase and squash the commits? 😃 |
…d not change Signed-off-by: carabasdaniel <dani@aserto.com>
srenatus
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the etag in the OCI downloader to store the SHA fixes issue #4637