Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage/disk: some follow ups #4519

Merged
merged 6 commits into from Mar 31, 2022
Merged

storage/disk: some follow ups #4519

merged 6 commits into from Mar 31, 2022

Commits on Mar 31, 2022

  1. storage/disk_test: check invalid patches with wildcard partition, too 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    bb70189 View commit details
    Browse the repository at this point in the history

  2. docs/disk: add caveat re: bundles loaded into memory 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    f8f483c View commit details
    Browse the repository at this point in the history

  3. storage/disk: auto-manage /system partitions 

    If these are found in the user-provided partitions, we'll error out.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    b39b0a9 View commit details
    Browse the repository at this point in the history

  4. storage/disk: pretty-print partitions with "*" instead of %2A 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    650c6c8 View commit details
    Browse the repository at this point in the history

  5. storage/disk: respect wildcard-replacement in partition validation 

    It is now allowed to replace a partition like

    /foo/bar

by

    /foo/*

also if multiple wildcards are used.

Caveats:

You cannot add a wildcard partition like /*/*, since it would overlap
the managed "/system/*" partition.

When attempting to go back from /foo/* to /foo/bar, an error is
raised _unconditionally_ -- we could check the existing data, but
currently don't.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    3c98f1e View commit details
    Browse the repository at this point in the history

  6. storage/disk: check prefix when adding wildcard partitions 

    The previously done check would have falsely returned that there is no problem
when adding a wildcard partition: lookup of "/foo/*" with '*' not interpreted
as a wildcard, but as a string, would yield a not-found, even if there was any
data under /foo/.

Now, we'll check the prefix-until-wildcard. It's more cautious than
theoretically necessary, but safe.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Mar 31, 2022
    Copy the full SHA
    8a9546c View commit details
    Browse the repository at this point in the history