downloader: log message on unexpected bundle content type #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if debug is the right log level, but since a wrong content-type header could be used to serve a valid bundle, it would likely be noisy to log this at higher levels. |
srenatus
previously approved these changes
Mar 14, 2022
anderseknert
force-pushed
the
bundle-dl-warn-on-funky-content-type
branch
from
d057df9
to
bdcb239
Compare
srenatus
previously approved these changes
Mar 15, 2022
srenatus
reviewed
Mar 15, 2022
anderseknert
force-pushed
the
bundle-dl-warn-on-funky-content-type
branch
from
175316b
to
c6c0593
Compare
|
I feel stuck on the race condition. Any help would be appreciated, @srenatus 🙂 |
|
a6698f7 maybe something along those lines? |
anderseknert
force-pushed
the
bundle-dl-warn-on-funky-content-type
branch
3 times, most recently
from
fc3a14a
to
b86e61a
Compare
srenatus
previously approved these changes
Mar 22, 2022
Fixes open-policy-agent#4278 Signed-off-by: Anders Eknert <anders@eknert.com>
anderseknert
force-pushed
the
bundle-dl-warn-on-funky-content-type
branch
from
b86e61a
to
01d82bc
Compare
srenatus
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4278
Signed-off-by: Anders Eknert anders@eknert.com