ast/compile: unused imports follow up #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanfylling
previously approved these changes
Mar 22, 2022
| Message: "import data.foo unused", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we also add test cases for when an import is used/not used as a rule value? E.g.
package p
import data.foo # unused
import data.bar
r = bar { true }and
package p
import data.foo # unused
import data.bar #unused
r = data.bar { true }
srenatus
force-pushed
the
sr/ast/strict/unused-imports-follow-up
branch
from
e933496
to
17082e9
Compare
* keep future imports untouched in check for unused imports Rationale: you might start out with a default header when creating a new rego policy -- there shouldn't be anything stopping you from using all the latest features then. * capture unused imports that are shadowed This would pretty much copy the work done in resolveAllRefs; so the extra check done as part of resolveAllRefs is advantageous: - we capture the cases when extra modules are lazily loaded - we don't walk all the code twice Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/strict/unused-imports-follow-up
branch
from
17082e9
to
9e71a27
Compare
|
Will merge when green ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a folllow-up to #4377.
The approach I had advised to take in #4377 fell a little short in the case of shadowed vars: Considering
and
we have a really hard time figuring out that the vars in those bodies are not actually making use of the imports.
To remedy this, we'll need to do the same work done in resolveAllRefs, which turned out to be much more involved than an
ast.Walk*.In the last commit, we're merging the check with the resolveAllRefs stage, because it's avoiding some extra work; and gives us better coverage if there are ever any lazily loaded modules.