Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: remove duplicates from coverage report #4410

Merged

Conversation

anderseknert
Copy link
Member

Thanks @srenatus for the suggested fix.

Fixes #4393

Signed-off-by: Anders Eknert anders@eknert.com

Fixes open-policy-agent#4393

Signed-off-by: Anders Eknert <anders@eknert.com>
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any reason why we'd want to keep those duplicates. 🧹

@anderseknert anderseknert merged commit cb01fba into open-policy-agent:main Mar 4, 2022
@anderseknert anderseknert deleted the fix-duplicate-coverage branch March 4, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPA is reporting back the wrong code coverage percentage and duplicating not_covered rows
2 participants