Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast/compile: 'every' rewriting steps #4231

Merged
merged 20 commits into from Jan 29, 2022
Merged

ast/compile: 'every' rewriting steps #4231

merged 20 commits into from Jan 29, 2022

Commits on Jan 29, 2022

  1. ast: prealloc expression 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    84c2c7c View commit details
    Browse the repository at this point in the history

  2. ast/visit: skip 'Every' Body when skipping closures 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    7f3380c View commit details
    Browse the repository at this point in the history

  3. ast/parser_ext: add MustParseModuleWithOpts, MustParseBodyWithOpts 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    b1ce68b View commit details
    Browse the repository at this point in the history

  4. ast/compile: 'every' rewriting (dynamic, declared vars) 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    4f9e3da View commit details
    Browse the repository at this point in the history

  5. ast/compile: simplify every rewriting (key/val are vars) 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    6f0b910 View commit details
    Browse the repository at this point in the history

  6. ast/compile: deal with wildcard cases 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    3227f5d View commit details
    Browse the repository at this point in the history

  7. ast/compile: add missing stack.Pop() 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    22ced5d View commit details
    Browse the repository at this point in the history

  8. ast/compile_test: fix indentation 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    b757da8 View commit details
    Browse the repository at this point in the history

  9. ast/compile: fix output vars of 'every' body 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    00e3896 View commit details
    Browse the repository at this point in the history

  10. ast/compile: safety check vars in every.Body 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    ddd81d8 View commit details
    Browse the repository at this point in the history

  11. ast/compile_test: add nested case for every rewriting 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    8e78ae7 View commit details
    Browse the repository at this point in the history

  12. ast/compiler: rewrite prints in 'every' bodies 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    8ac09b4 View commit details
    Browse the repository at this point in the history

  13. ast/compile_test: add "rewrite dynamics" tests for "every" 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    0b72c1c View commit details
    Browse the repository at this point in the history

  14. ast/compile: expand "every" domain 

    There's one broken test that I haven't figured out how to fix yet.

From the perspective of topdown, this change felt right, it will
simplify evaluation.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    3954eb3 View commit details
    Browse the repository at this point in the history

  15. ast/compile: outputVarsForExpr: don't return vars from "Every" body 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    0f1bfe0 View commit details
    Browse the repository at this point in the history

  16. ast/compile: fix safety reordering for every 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    9289cb5 View commit details
    Browse the repository at this point in the history

  17. ast: rename (Every).Vars() -> (Every).KeyValueVars() 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    decbdb1 View commit details
    Browse the repository at this point in the history

  18. ast/compile: use VarVisitor for KeyValueVars() 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    5f41d87 View commit details
    Browse the repository at this point in the history

  19. ast/compile: add ContainsClosures 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    46478b6 View commit details
    Browse the repository at this point in the history

  20. ast/compile_test: add unused assigned var in "every" body case 

    Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
    @srenatus
    srenatus committed Jan 29, 2022
    Copy the full SHA
    5f5da56 View commit details
    Browse the repository at this point in the history