ast+topdown: cache array groundness #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Dec 16, 2021
Comment on lines
+44
to
+46
| module := `package test | ||
| fixture := data.fixture | ||
| main { x := fixture }` |
There was a problem hiding this comment.
I had to make this benchmark oddly specific to see an effect:
name old time/op new time/op delta
ArrayPlugging/10-16 14.4µs ± 1% 14.3µs ± 3% ~ (p=0.690 n=5+5)
ArrayPlugging/100-16 22.7µs ±11% 21.0µs ±14% ~ (p=0.095 n=5+5)
ArrayPlugging/1000-16 95.4µs ± 8% 77.8µs ± 5% -18.41% (p=0.008 n=5+5)
ArrayPlugging/10000-16 852µs ± 4% 685µs ± 2% -19.55% (p=0.008 n=5+5)
name old alloc/op new alloc/op delta
ArrayPlugging/10-16 9.83kB ± 0% 9.71kB ± 0% -1.22% (p=0.008 n=5+5)
ArrayPlugging/100-16 15.1kB ± 0% 14.1kB ± 0% -6.22% (p=0.008 n=5+5)
ArrayPlugging/1000-16 65.7kB ± 0% 57.5kB ± 0% -12.54% (p=0.008 n=5+5)
ArrayPlugging/10000-16 574kB ± 0% 492kB ± 0% -14.30% (p=0.008 n=5+5)
name old allocs/op new allocs/op delta
ArrayPlugging/10-16 191 ± 0% 188 ± 0% -1.57% (p=0.008 n=5+5)
ArrayPlugging/100-16 371 ± 0% 368 ± 0% -0.81% (p=0.008 n=5+5)
ArrayPlugging/1000-16 2.17k ± 0% 2.17k ± 0% -0.14% (p=0.008 n=5+5)
ArrayPlugging/10000-16 20.2k ± 0% 20.2k ± 0% -0.01% (p=0.008 n=5+5)
srenatus
commented
Dec 16, 2021
| @@ -104,6 +107,9 @@ func (u *bindings) plugNamespaced(a *ast.Term, caller *bindings) *ast.Term { | |||
| }) | |||
| return &cpy | |||
| case ast.Set: | |||
There was a problem hiding this comment.
For the other three shortcuts added here, I have not yet thought about when they'd happen -- they do seem to make sense in a pattern-match kind of way 🙃
srenatus
force-pushed
the
sr/ast/cache-array-groundness
branch
from
bcc3f0e
to
5bf956c
Compare
tsandall
previously approved these changes
Dec 16, 2021
|
OK great. I'll update this and get it merged. |
I had been believing that we couldn't do this, since many methods allow changing an array's elements in ways that would invalidate the cached groundness bit. However, if we don't do that, we're OK. To get the tests to pass, the walk builtin implementation had implicitly depended on array plugging returning a copy; that's now made explicit. In topdown/bindings, this adds a few more shortcuts where applicable (array/set). Previously, only objects had a ground?- shortcutin plugging and namespacing vars. Fixes open-policy-agent#3679. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/cache-array-groundness
branch
from
5bf956c
to
1842468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been believing that we couldn't do this, since many methods allow changing an array's elements in ways that would invalidate the cached groundness bit. However, if we don't do that, we're OK.
To get the tests to pass, the
walkbuiltin implementation had implicitly depended on array plugging returning a copy; that's now made explicit.Fixes #3679.