server+runtime: add cert refreshing #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/server+runtime/add-cert-refreshing
branch
from
2be9a7c
to
981c05f
Compare
srenatus
force-pushed
the
sr/server+runtime/add-cert-refreshing
branch
2 times, most recently
from
4170582
to
8773707
Compare
superff
previously approved these changes
Dec 9, 2021
tsandall
previously approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Let's add a note about the new flag to this section of the security docs: https://www.openpolicyagent.org/docs/latest/security/#tls-and-https. Otherwise, these changes LGTM. Feel free to merge whenever.
|
🤦 I somehow dropped my docs commit on the floor. I'll go find it 😅 |
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
…run.go Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
With two flags, one for enable/disable and one for the period of refreshes, we can avoid overloading the period flag with something like "0" disables. There's no need to use the VarP etc variants if the flag has no shorthand. So, cleaned up a few of those. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/server+runtime/add-cert-refreshing
branch
2 times, most recently
from
a19f53c
to
373ca6f
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/server+runtime/add-cert-refreshing
branch
from
373ca6f
to
6a8d482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag to
opa run, intended for server usage with HTTPS listeners:--tls-cert-refresh-period. If used with a positive duration, such as "5m" (5 minutes),"24h", etc, the server will track the certificate and key files' contents. When their
content changes, the certificates will be reloaded.
On an error in reloading, it will log (info) the error and try again in the next round.
Fixes #2500.