ast/compile: check arity in undefined function stage #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/ast/compile-check-arity-when-checking-undefined-functions
branch
2 times, most recently
from
bfb2452
to
19ac7c4
Compare
tsandall
reviewed
Nov 30, 2021
Before, the "undefined function" check stage in the compiler (and query compiler) only asserted that the function was known. Now, we'll also check that the number of arguments _could be_ valid. If it really is valid will be determined by the type checker at a later stage. However, asserting the arity early allows us to give more on-the-spot error messages. Fixes open-policy-agent#4054. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/compile-check-arity-when-checking-undefined-functions
branch
from
bd6bd89
to
f912b48
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/ast/compile-check-arity-when-checking-undefined-functions
branch
from
f912b48
to
fa4ad03
Compare
srenatus
deleted the
sr/ast/compile-check-arity-when-checking-undefined-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the "undefined function" check stage in the compiler (and query
compiler) only asserted that the function was known.
Now, we'll also check that the number of arguments could be valid. If
it really is valid will be determined by the type checker at a later
stage.
However, asserting the arity early allows us to give more on-the-spot
error messages.
Fixes #4054.