Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topdown: Added a new array reverse function #3979

Closed
wants to merge 4 commits into from

Conversation

olamiko
Copy link
Contributor

@olamiko olamiko commented Nov 5, 2021

ast: Updated the builtins list

partially fixes #3736

Signed-off-by: Olamide Omolola omololaolamidex@gmail.com

ast: Updated the builtins list

partially fixes open-policy-agent#3736

Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
@anderseknert
Copy link
Member

Lint failures, and needs unit tests, but looks like a good start!

ast: Updated the builtins list

partially fixes open-policy-agent#3736

Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
Signed-off-by: Olamide Omolola <omololaolamidex@gmail.com>
@srenatus
Copy link
Contributor

Heya. Are you still working on this? 😃

@olamiko
Copy link
Contributor Author

olamiko commented Nov 23, 2021

Hi @srenatus, yes, I already wrote the functions for reversing. Next step is to test them and then update the website

@srenatus srenatus marked this pull request as draft December 1, 2021 09:53
@srenatus
Copy link
Contributor

srenatus commented Dec 1, 2021

@olamiko I've converted this to a draft. Please check "Ready for review" when you get to pick this up 🚀

@tsandall
Copy link
Member

Closing this due to inactivity.

@tsandall tsandall closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a built-in function to reverse arrays and strings
4 participants