information request: long polling seem's bugged on 304 http status code. #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for adding the fix @floriangasc! What do you think about adding a new field on the Downloader object to keep of the long poll status ? We would set it in the oneShot method based on the response from the download method. Then on a 304 we would return longPoll: d.longPoll instead of longPoll: isLongPollSupported(resp.Header).
Signed-off-by: Gasc Florian <florian.gasc@gmail.com> Fixes: open-policy-agent#3923
floriangasc
force-pushed
the
little-work-on-bunle-downloader
branch
from
f07d223
to
78c2337
Compare
|
Thank's for quick reply. I have response on another P.R:r: #3926. Please, excuse me for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gasc Florian florian.gasc@gmail.com
Fixes #3923