Commits on Aug 25, 2020

1. types: Fix panic on reference to object with composite key …

   The type checker was panicing when given a reference to an object with
   a composite key because internally it infers the key type using
   ast.ValueToInterface (which returns map[string]interface{} and not
   map[interface{}]interface{}). This change updates the types package to
   support map[string]interface{} internally.
   
   Fixing the TypeOf function resolved the panic but it surfaced another
   issue in the type checker where errors were returned if objects or
   arrays were dereferenced with composite keys--in case of arrays, the
   result is undefined but in the case of objects, this is valid.
   
   Fixes open-policy-agent#2648
   
   Signed-off-by: Torin Sandall <torinsandall@gmail.com>

   

   tsandall committed Aug 25, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for e3ffa5e
   • Browse repository at this point

   Copy the full SHA

   e3ffa5e View commit details

   Browse the repository at this point in the history

2. ast: Fix compiler to expand exprs in rule args …

   Previously the compiler was not rewriting expr terms in the rule
   args. In particular, this meant that indirect refs were not being
   rewritten. This would lead to panics in the safety check which assume
   that indirect refs have been rewritten (in other words, that reference
   heads are always variables.)
   
   This commit just updates the expr term rewriting to process rule args
   as it does for the rule head key and value terms.
   
   Fixes open-policy-agent#2649
   
   Signed-off-by: Torin Sandall <torinsandall@gmail.com>

   

   tsandall committed Aug 25, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 8a411ef
   • Browse repository at this point

   Copy the full SHA

   8a411ef View commit details

   Browse the repository at this point in the history