Add response header timeout and update discovery bundle status #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new configurable timeout to the Services config to set the amount of time to wait for the server's response headers. With this change, the client will no longer wait indefinitely for the HTTP request to complete. Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar
force-pushed
the
http-client-timeout
branch
from
091ddf8
to
5ceab61
Compare
…n discovery status This commmit sets the values for the last request and last successful request in the discovery bundle status. Fixes: open-policy-agent#2630 Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
ashutosh-narkar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes include:
A new configurable timeout to the Services
config to set the amount of time to wait for the server's
response headers. Fixes: Service clients should timeout HTTP requests if no response is received #2014
Logic to set the values for the last request and last successful request
in the discovery bundle status. Fixes: Error status being report from OPA's discovery bundle #2630
Signed-off-by: Ashutosh Narkar anarkar4387@gmail.com