allow clients to provide decision_id #1465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 3, 2019 17:11
Signed-off-by: omerlh <omerl@soluto.com>
Signed-off-by: omerlh <omerl@soluto.com>
patrick-east
reviewed
Jun 3, 2019
There was a problem hiding this comment.
Looks like it isn't passing the make check tests https://travis-ci.org/open-policy-agent/opa/builds/540773146?utm_source=github_status&utm_medium=notification
./build/check-fmt.sh
./build/check-vet.sh
./build/check-lint.sh
/home/travis/gopath/src/github.com/open-policy-agent/opa/server/server_test.go:2466:2: don't use underscores in Go names; var decision_id should be decisionID
/home/travis/gopath/src/github.com/open-policy-agent/opa/server/types/types.go:444:2: const ParamDecisionIdV1 should be ParamDecisionIDV1
make: *** [check-lint] Error 1
The command "make" exited with 2.
docs/content/rest-api.md
Outdated
| @@ -1049,6 +1049,7 @@ The request body contains an object that specifies a value for [The input Docume | |||
| - **metrics** - Return query performance metrics in addition to result. See [Performance Metrics](#performance-metrics) for more detail. | |||
| - **instrument** - Instrument query evaluation and return a superset of performance metrics in addition to result. See [Performance Metrics](#performance-metrics) for more detail. | |||
| - **watch** - Set a watch on the data reference if the parameter is present. See [Watches](#watches) for more detail. | |||
| - **decision_id** - The decision id to use for logging. Allow clients to supply it, instead of auto generated number. | |||
There was a problem hiding this comment.
Maybe reword this to:
Client supplied decision ID to use for tracing. If not specified a random ID is generated automatically.
added 2 commits
June 4, 2019 07:58
Signed-off-by: omerlh <omerl@soluto.com>
Signed-off-by: omerlh <omerl@soluto.com>
srenatus
previously approved these changes
Jun 4, 2019
server/server.go
Outdated
| @@ -2083,6 +2084,22 @@ func validateParsedQuery(body ast.Body) ([]string, error) { | |||
| return unsafeOperators, nil | |||
| } | |||
|
|
|||
| func getStringParam(url *url.URL, name string, ifEmpty string) string { | |||
|
|
|||
| p, ok := url.Query()[name] | |||
There was a problem hiding this comment.
[nit] It's not a deep change, but we could use (Values).Get, too:
if p := url.Query().Get(name); p != "" {
return p
}
return ifEmptyIt doesn't do much, so it also doesn't matter if we use it or not, I suppose 😉
There was a problem hiding this comment.
Thanks! It make the code a bit cleaner :)
Signed-off-by: omerlh <omerl@soluto.com>
omerlh
force-pushed
the
custom_decision_id
branch
from
09eed86
to
1a64d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: omerlh omerl@soluto.com
close #1451