Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI: Bundles are reloaded and activated unconditionally #4637

Closed
srenatus opened this issue Apr 28, 2022 · 1 comment
Closed

OCI: Bundles are reloaded and activated unconditionally #4637

srenatus opened this issue Apr 28, 2022 · 1 comment
Labels

Comments

@srenatus
Copy link
Contributor

When using an OCI registry for bundle storage (#4518), each periodic call to the OCI reg will now fetch the bundle, and load and activate it.

For HTTP sources, we're using the ETag. We could probably record the digest of the OCI artifact? Or use it as ETag...?

👉 https://github.com/open-policy-agent/opa/blob/v0.40.0/download/oci_dowload.go#L101-L103

@viovanov
Copy link
Contributor

viovanov commented May 3, 2022

I think we should use the digest. AFAIK, we're not downloading layers already downloaded, but the bundle is loaded/activated each time anyway.
I think if the digest has not changed, the bundle should not be loaded/activated.

cc @carabasdaniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants