topdown: deal with default functions #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure enough, the wasm tests need an exception here, because they implement the defaults differently. |
srenatus
force-pushed
the
sr/issue-default-functions
branch
from
0d0e2e9
to
e993550
Compare
They aren't supported, but they can lead to a situation where ir.Empty() is false, but ir.Rules still has length 0. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/issue-default-functions
branch
from
e993550
to
e8b1f3c
Compare
tsandall
approved these changes
May 28, 2021
rogeriopeixotocx
added a commit
to Checkmarx/kics
that referenced
this pull request
Jun 18, 2021
Reverting PR #3503 These are the two queries failing: https://github.com/Checkmarx/kics/blob/master/assets/queries/k8s/volume_mount_with_os_directory_write_permissions/query.rego https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/kubernetes/volume_mount_with_os_directory_write_permissions/query.rego We should check if this has anything to do with either: open-policy-agent/opa#3501 open-policy-agent/opa#3505 *UPDATE* This new query #3651 is failing after the update. This might be related to this issue open-policy-agent/opa#3546
rogeriopeixotocx
added a commit
to Checkmarx/kics
that referenced
this pull request
Jun 18, 2021
Reverting PR #3503 These are the two queries failing: https://github.com/Checkmarx/kics/blob/master/assets/queries/k8s/volume_mount_with_os_directory_write_permissions/query.rego https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/kubernetes/volume_mount_with_os_directory_write_permissions/query.rego We should check if this has anything to do with either: open-policy-agent/opa#3501 open-policy-agent/opa#3505 *UPDATE* This new query #3651 is failing after the update. This might be related to this issue open-policy-agent/opa#3546 Signed-off-by: Rogério Peixoto <rogerio.peixoto@checkmarx.com>
rogeriopeixotocx
added a commit
to Checkmarx/kics
that referenced
this pull request
Jun 18, 2021
Reverting PR #3503 These are the two queries failing: https://github.com/Checkmarx/kics/blob/master/assets/queries/k8s/volume_mount_with_os_directory_write_permissions/query.rego https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/kubernetes/volume_mount_with_os_directory_write_permissions/query.rego We should check if this has anything to do with either: open-policy-agent/opa#3501 open-policy-agent/opa#3505 *UPDATE* This new query #3651 is failing after the update. This might be related to this issue open-policy-agent/opa#3546 Signed-off-by: Rogério Peixoto <rogerio.peixoto@checkmarx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They aren't supported, but they can lead to a situation where
ir.Empty() is false, but ir.Rules still has length 0.
Signed-off-by: Stephan Renatus stephan.renatus@gmail.com