Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): reverting OPA v0.29.4 to v0.28.0 #3702

Merged
merged 1 commit into from Jun 18, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

Reverting PR #3503

These are the two queries failing:
https://github.com/Checkmarx/kics/blob/master/assets/queries/k8s/volume_mount_with_os_directory_write_permissions/query.rego
https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/kubernetes/volume_mount_with_os_directory_write_permissions/query.rego

We should check if this has anything to do with either:
open-policy-agent/opa#3501
open-policy-agent/opa#3505

UPDATE
This new query #3651 is failing after the update.
This might be related to this issue open-policy-agent/opa#3546

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 18, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Core Engineering milestone Jun 18, 2021
@rogeriopeixotocx rogeriopeixotocx requested a review from a team June 18, 2021 10:41
@rogeriopeixotocx rogeriopeixotocx self-assigned this Jun 18, 2021
@rogeriopeixotocx rogeriopeixotocx added this to In progress in KICS Engine via automation Jun 18, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jun 18, 2021

Scan submitted to Checkmarx

felipe-avelar
felipe-avelar previously approved these changes Jun 18, 2021
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kicsbot
Copy link
Contributor

kicsbot commented Jun 18, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Reverting PR #3503

These are the two queries failing:
https://github.com/Checkmarx/kics/blob/master/assets/queries/k8s/volume_mount_with_os_directory_write_permissions/query.rego
https://github.com/Checkmarx/kics/blob/master/assets/queries/terraform/kubernetes/volume_mount_with_os_directory_write_permissions/query.rego

We should check if this has anything to do with either:
open-policy-agent/opa#3501
open-policy-agent/opa#3505

*UPDATE*
This new query #3651 is failing after the update.
This might be related to this issue open-policy-agent/opa#3546

Signed-off-by: Rogério Peixoto <rogerio.peixoto@checkmarx.com>
KICS Engine automation moved this from In progress to Pending code review Jun 18, 2021
@rogeriopeixotocx rogeriopeixotocx requested review from felipe-avelar and a team June 18, 2021 11:11
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 174de86 into master Jun 18, 2021
KICS Engine automation moved this from Pending code review to Done Jun 18, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/revert-opa-0.29.4-to-0.28.0 branch June 18, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants