Updates to Elasticsearch filter example to utilize the new SDK functionality #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kroekle thanks for the contribution. Can you please sign-off the commit and add a comment once open-policy-agent/opa#4240 is merged. Thanks. |
Signed-off-by: Kurt Roekle <kroekle@gmail.com>
changed resolver term to mapper added additional function to mapper for changing to json added test for mapper
changed resolver term to mapper added additional function to mapper for changing to json added test for mapper Signed-off-by: Kurt Roekle <kroekle@gmail.com>
… sdk_partial Signed-off-by: Kurt Roekle <kroekle@gmail.com>
… sdk_partial Signed-off-by: Kurt Roekle <kroekle@gmail.com>
Signed-off-by: Matthieu FRONTON <m@tthieu.fr> Signed-off-by: Kurt Roekle <kroekle@gmail.com>
Signed-off-by: Umesh Moghariya <um3shpm@gmail.com> Signed-off-by: Kurt Roekle <kroekle@gmail.com>
Signed-off-by: Kurt Roekle <kroekle@gmail.com>
changed resolver term to mapper added additional function to mapper for changing to json added test for mapper Signed-off-by: Kurt Roekle <kroekle@gmail.com>
|
Is this still needed with #164 merged? If so we'll need to have this rebased from the latest main. |
|
So the intent of this PR was to utilize the SDK to do the call, so I think
it's still relevant. With all the changes it might be easier for me to
just start over. I think I'll close this one out and open another when I
have some time.
…On Sun, Mar 27, 2022 at 11:41 AM Anders Eknert ***@***.***> wrote:
Is this still needed with #164
<#164> merged? If so
we'll need to have this rebased from the latest main.
—
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAES32UYWEGZLIC42TOL24LVCC2X7ANCNFSM5MHR32GA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sounds good @kroekle 👍 |
|
Due to all the recent changes to both the elasticsearch example to OPA SDK itself, I will close this and open another one later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on open-policy-agent/opa#4240
Updating the Elasticsearch example to use the new functionality in the SDK that will allow for partial evaluation. This should allow for utilizing the OPA configuration (i.e. bundle, decisions, etc) when using partial evaluation.