Issue #575 - Select boxes rendering #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 88.49% 88.55% +0.05%
==========================================
Files 420 432 +12
Lines 7750 8000 +250
Branches 654 683 +29
==========================================
+ Hits 6858 7084 +226
- Misses 754 767 +13
- Partials 138 149 +11
Continue to review full report at Codecov.
|
| @@ -253,6 +255,30 @@ def get_merged_data(self) -> dict: | |||
|
|
|||
| return merged_data | |||
|
|
|||
| def get_printable_data(self) -> Dict[str, str]: | |||
There was a problem hiding this comment.
Fine for now, but if we keep expanding on this, we might have to just register a display/print function which takes the info argument and have a mapping of type: print_function so that can be tested/maintained in a bit more isolated way.
sergei-maertens
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
In the same way that the files attachment have a special treatment for rendering them in the report, now also the select boxes have a special treatment.
I also updated the submission report template to prevent the table with the form data to run outside the page.
Note: If the label/value from a field are an extremely long word, this will still render in an ugly way. It is due to this bug in weasyprint: Kozea/WeasyPrint#36