Devan/upgrade django

[DevanR]

This PR contains the changes required to upgrade the from the current version of Django. 1.10.7 to 1.11. The main steps taken to achieve this were as follows:

update SwampDragon to fork that supports Django 1.11
update Django to 1.11
resolve django-angular issues

Dependencies: None

Testing instructions:

• install and setup opencraft devstack on your local machine (https://github.com/open-craft/opencraft)
• run make test.unit to verify installation works
• switch to devan/upgrade-django branch
• run pip install -r requirements.txt
• run make test.unit to verify installation
• runmake run.dev
• go to http://localhost:5000/registration/ and register

Author notes:

SwampDragon fork that supports Django 1.11:
https://github.com/lepri/swampdragon/commits/master

Django 1.11 removes ChoiceFieldRenderer class:
jrief/django-angular#284

Django 1.11 support for django-angular:
jrief/django-angular#292

Pylint issues with Django 1.11:
pylint-dev/pylint#1653

Reviewers

• @SSPJ

[SSPJ]

@DevanR I had a look. Good work tracking down a compatible version of swampdragon. When I run pip install on your branch I still get swampdragon 0.4.2.2 has requirement Django<1.10,>=1.6, but you'll have django 1.11.20 which is incompatible. Do you get that also?

Also, when I run the unit tests on master, I get 22 failures FAILED (failures=22, errors=15, skipped=23) (I know, I shouldn't be getting any) but when I run them on your branch I get 27, i.e. FAILED (failures=27, errors=15, skipped=23). I am running them again to log to a file to see which exact tests are failing, but do you have any insight on it?

[SSPJ]

@DevanR I see that the extra failing tests are:

> FAIL: test_existing_user (registration.tests.test_views.BetaTestApplicationViewTestCase)
> FAIL: test_valid_application (registration.tests.test_views.BetaTestApplicationViewTestCase)
> FAIL: test_valid_subdomain_1_hogwarts (registration.tests.test_views.BetaTestApplicationViewTestCase)
> FAIL: test_valid_subdomain_2_hog_warts (registration.tests.test_views.BetaTestApplicationViewTestCase)
> FAIL: test_valid_subdomain_3_hog1warts (registration.tests.test_views.BetaTestApplicationViewTestCase)

I also saw the note on the ticket description. Is this because you need to rebase on master?

[DevanR]

@SSPJ Strange, I'm not getting any failing tests. Plus, the extra failing tests should have been fixed by the last commit. Let me double check and get back to you. Thanks for the review so far.

[DevanR]

@SSPJ I've push a fixed for the additional failing tests (not sure why I did not pick them up before. And I'm even more confused why CircleCI tests passed.) Could you please do 'vagrant destroy && vagrant up && vagrant ssh' and run 'make test' again? I'm getting all tests passing on my local environment. Hopefully CircleCI will show the same.

[SSPJ]

@DevanR I wouldn't worry about the extra failing tests on my devstack. Those are because I don't have all my variables configured properly. But I ran the provisioning again and your branch now has 22 failures, same as master, and I was able to register an account, so nice work!

As soon as you fix the failing Jasmine tests, this should be good to merge. 👍

[DevanR]

@SSPJ All the tests seem to be passing now. Could you please have another look?

[SSPJ]

Looks good, @DevanR 👍

• I tested this: registered a user on this branch and ran make test
• I read through the code
• I checked for accessibility issues n/a
• Includes documentation n/a