SBERDOMA-872 update and configure jest #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFoxPro
added
the
🔬 WIP
MrFoxPro
force-pushed
the
feature/condo/SBERDOMA-872/update_and_configure_jest
branch
from
191104e
to
e9ccffa
Compare
AntonAL
reviewed
Jul 27, 2021
MrFoxPro
added
✋🙂 Review please
MrFoxPro
force-pushed
the
feature/condo/SBERDOMA-872/update_and_configure_jest
branch
from
cec1427
to
6f9f408
Compare
|
We need to check:
|
Dimitreee
approved these changes
Jul 29, 2021
leonid-d
approved these changes
Jul 30, 2021
pahaz
reviewed
Aug 2, 2021
| @@ -8,7 +8,8 @@ const { MESSAGE_SENDING_STATUS, MESSAGE_RESENDING_STATUS, MESSAGE_DELIVERED_STAT | |||
| const sleep = async (time) => (new Promise((resolve => { | |||
| setTimeout(resolve, time) | |||
| }))) | |||
|
|
|||
| // https://github.com/facebook/jest/issues/11500 | |||
| jest.setTimeout(30000) | |||
There was a problem hiding this comment.
it's better to move it inside https://github.com/open-condo-software/condo/blob/master/apps/condo/jest.setup.js
pahaz
reviewed
Aug 2, 2021
| @@ -84,3 +84,4 @@ jobs: | |||
| DATABASE_URL: ${{ matrix.database }} | |||
| NODE_ENV: development | |||
| DISABLE_LOGGING: true | |||
| IN_CI: true | |||
pahaz
reviewed
Aug 2, 2021
| silent: true, | ||
| verbose: false, | ||
| // https://stackoverflow.com/questions/43864793/why-does-jest-runinband-speed-up-tests | ||
| maxWorkers: conf.IN_CI ? 1 : 4, |
There was a problem hiding this comment.
it's better to fix the tests to support parallel mode
pahaz
requested changes
Aug 2, 2021
| @@ -97,7 +97,9 @@ | |||
| "@types/react": "^17.0.1", | |||
| "babel-jest": "^26.6.3", | |||
| "identity-obj-proxy": "^3.0.0", | |||
| "jest": "^26.6.3", | |||
| "jest": "27.0.6", | |||
| "jest-clean-reporter": "https://github.com/MrFoxPro/jest-clean-reporter", | |||
pahaz
reviewed
Aug 2, 2021
| @@ -14,5 +16,13 @@ beforeAll(async () => { | |||
| }) | |||
|
|
|||
| afterAll(async () => { | |||
| if (redisGuard.db) { | |||
pahaz
reviewed
Aug 2, 2021
| verbose: false, | ||
| // https://stackoverflow.com/questions/43864793/why-does-jest-runinband-speed-up-tests | ||
| maxWorkers: conf.IN_CI ? 1 : 4, | ||
| noStackTrace: true, |
There was a problem hiding this comment.
is it ok to disable stack trace for all developers?
pahaz
reviewed
Aug 2, 2021
| return adapter | ||
| } else { | ||
| throw new Error(`getAdapter() call with unknown schema: ${databaseUrl}`) | ||
| } | ||
| } | ||
|
|
||
| let redisClientHandler = {} |
|
Why you don't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.