Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --argument-passthrough option #68

Closed
wants to merge 1 commit into from
Closed

Add --argument-passthrough option #68

wants to merge 1 commit into from

Conversation

MadLittleMods
Copy link

@MadLittleMods MadLittleMods commented Oct 31, 2016

Fixes https://github.com/kimmobrunfeldt/concurrently/issues/33

Add --argument-passthrough option

Barebones example

concurrently --argument-passthrough "echo foo" "echo bar" -- --some-arg
->
echo foo --some-arg
echo bar --some-arg

With npm scripts

concurrently --argument-passthrough "npm run foo" "npm run bar" -- -- --some-arg
-> 
npm run foo -- --some-arg
npm run bar -- --some-arg

Todo

  • Figure out best way to test this (suggestions welcome)

@MadLittleMods
Copy link
Author

@kimmobrunfeldt Friendly ping for thoughts and timeline

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you prefer to skip --arguments-passthrough?
So as soon as you have -- bla, the arguments are passed through 😉

However, if you have examples of programs that work similarly, we could review the need of such option.

@MadLittleMods
Copy link
Author

MadLittleMods commented Jan 27, 2017

@gustavohenke Having no option seems fine. Any thoughts on how to test?

@gustavohenke
Copy link
Member

Codebase changed significantly and this PR has been inactive for a good time.
I'm closing it; feel free to open an issue to discuss the approach before starting over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants