Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export named concurrently + fix TS errors with Node16 #456

Merged
merged 8 commits into from Feb 4, 2024
Merged

Conversation

gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented Dec 14, 2023

Fixes a bunch of issues when using concurrently

  1. For require() function (from both TS and pure JS)
  2. With TS + import syntax, but without ES module interop
  3. With TS + import syntax, but with ES module interop
  4. As an ES Module (from both TS and pure JS)

On the side, the named export concurrently is now the fully configured concurrently.
This was done to simplify the exports in the index files (most likely specific to ESM, but I've lost track of why exactly).

Will add some smoke tests in a follow up PR so that this one stays mostly focused to the core changes.

Fixes #399
Fixes #454
Closes #440

@coveralls
Copy link

coveralls commented Dec 14, 2023

Coverage Status

coverage: 99.2% (+0.003%) from 99.197%
when pulling e160bd3 on issue-399
into 0c64306 on main.

@gustavohenke gustavohenke marked this pull request as ready for review January 4, 2024 15:03
@gustavohenke gustavohenke added this to the v9 milestone Jan 12, 2024
@gustavohenke
Copy link
Member Author

Bit of a bump @paescuj, might proceed without a review in a few days

@gustavohenke gustavohenke merged commit feac92b into main Feb 4, 2024
21 checks passed
@gustavohenke gustavohenke deleted the issue-399 branch February 4, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants