update install command to use --save-dev
#376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It's arguable.
Using concurrently to spin up multiple build tools at once is pretty common, so it fits correctly the description of a dev tool.
On the other hand, you could have multiple services in a production server that need to be respawned when one of them dies.
I'm not saying that this is a good practise, but it's a valid use case for concurrently.
@paescuj opinions?
|
I'm in favor of this change for the following two reasons:
I also think this is a valid use case, but let's leave it to the users to declare "concurrently" as a productive dependency in this case. |
fwouts
pushed a commit
to fwouts/previewjs
that referenced
this pull request
Nov 25, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [concurrently](https://togithub.com/open-cli-tools/concurrently) | [`7.5.0` -> `7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>open-cli-tools/concurrently</summary> ### [`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0) #### What's Changed - Support percent values in maxProcesses by [@​lynxtaa](https://togithub.com/lynxtaa) in [open-cli-tools/concurrently#375 - Enable TypeScript strict mode by [@​gustavohenke](https://togithub.com/gustavohenke) in [open-cli-tools/concurrently#374 - update install command to use `--save-dev` by [@​DetachHead](https://togithub.com/DetachHead) in [open-cli-tools/concurrently#376 - Correct wildcard naming as described in README by [@​paescuj](https://togithub.com/paescuj) in [open-cli-tools/concurrently#385 #### New Contributors - [@​lynxtaa](https://togithub.com/lynxtaa) made their first contribution in [open-cli-tools/concurrently#375 - [@​DetachHead](https://togithub.com/DetachHead) made their first contribution in [open-cli-tools/concurrently#376 **Full Changelog**: open-cli-tools/concurrently@v7.5.0...v7.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMzMuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to defenseunicorns/zarf
that referenced
this pull request
Nov 25, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [concurrently](https://togithub.com/open-cli-tools/concurrently) | [`7.5.0` -> `7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-cli-tools/concurrently</summary> ### [`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0) #### What's Changed - Support percent values in maxProcesses by [@​lynxtaa](https://togithub.com/lynxtaa) in [open-cli-tools/concurrently#375 - Enable TypeScript strict mode by [@​gustavohenke](https://togithub.com/gustavohenke) in [open-cli-tools/concurrently#374 - update install command to use `--save-dev` by [@​DetachHead](https://togithub.com/DetachHead) in [open-cli-tools/concurrently#376 - Correct wildcard naming as described in README by [@​paescuj](https://togithub.com/paescuj) in [open-cli-tools/concurrently#385 #### New Contributors - [@​lynxtaa](https://togithub.com/lynxtaa) made their first contribution in [open-cli-tools/concurrently#375 - [@​DetachHead](https://togithub.com/DetachHead) made their first contribution in [open-cli-tools/concurrently#376 **Full Changelog**: open-cli-tools/concurrently@v7.5.0...v7.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Noxsios
pushed a commit
to defenseunicorns/zarf
that referenced
this pull request
Mar 8, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [concurrently](https://togithub.com/open-cli-tools/concurrently) | [`7.5.0` -> `7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-cli-tools/concurrently</summary> ### [`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0) [Compare Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0) #### What's Changed - Support percent values in maxProcesses by [@​lynxtaa](https://togithub.com/lynxtaa) in [open-cli-tools/concurrently#375 - Enable TypeScript strict mode by [@​gustavohenke](https://togithub.com/gustavohenke) in [open-cli-tools/concurrently#374 - update install command to use `--save-dev` by [@​DetachHead](https://togithub.com/DetachHead) in [open-cli-tools/concurrently#376 - Correct wildcard naming as described in README by [@​paescuj](https://togithub.com/paescuj) in [open-cli-tools/concurrently#385 #### New Contributors - [@​lynxtaa](https://togithub.com/lynxtaa) made their first contribution in [open-cli-tools/concurrently#375 - [@​DetachHead](https://togithub.com/DetachHead) made their first contribution in [open-cli-tools/concurrently#376 **Full Changelog**: open-cli-tools/concurrently@v7.5.0...v7.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concurrently is a dev tool so it should be saved to
devDependencies