Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support percent values in maxProcesses #375

Merged
merged 3 commits into from Oct 26, 2022

Conversation

lynxtaa
Copy link
Contributor

@lynxtaa lynxtaa commented Oct 26, 2022

Support percentage based value for maxProcesses: it could be beneficial for environments with variable CPUs available

@coveralls
Copy link

coveralls commented Oct 26, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 47a9185 on lynxtaa:percent-processes into 875d2df on open-cli-tools:main.

Copy link
Collaborator

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request, @lynxtaa! ❤️
I've only a few change requests, besides those it looks very good.

src/concurrently.spec.ts Show resolved Hide resolved
src/concurrently.ts Outdated Show resolved Hide resolved
src/concurrently.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/concurrently.ts Outdated Show resolved Hide resolved
src/concurrently.spec.ts Outdated Show resolved Hide resolved
src/concurrently.spec.ts Outdated Show resolved Hide resolved
src/concurrently.spec.ts Outdated Show resolved Hide resolved
@paescuj
Copy link
Collaborator

paescuj commented Oct 26, 2022

(@gustavohenke Would you mind enabling the Allow auto-merge option for this repository so I don't have to wait until all checks have been completed? 😄)

@paescuj paescuj merged commit 07e8223 into open-cli-tools:main Oct 26, 2022
@lynxtaa lynxtaa deleted the percent-processes branch October 26, 2022 09:02
fwouts pushed a commit to fwouts/previewjs that referenced this pull request Nov 25, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMzMuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to defenseunicorns/zarf that referenced this pull request Nov 25, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Noxsios pushed a commit to defenseunicorns/zarf that referenced this pull request Mar 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants