Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onFinish signature when using exactOptionalPropertyTypes #372

Merged
merged 1 commit into from Oct 15, 2022
Merged

Fix onFinish signature when using exactOptionalPropertyTypes #372

merged 1 commit into from Oct 15, 2022

Conversation

Baune8D
Copy link
Contributor

@Baune8D Baune8D commented Oct 12, 2022

Seeing this error:

image

When consuming concurrently in a project with exactOptionalPropertyTypes enabled.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 20c16bb on Baune8D:fix-handle-return-signature into 54b56c6 on open-cli-tools:main.

@paescuj
Copy link
Collaborator

paescuj commented Oct 13, 2022

Thanks @Baune8D! I'm going to take a look at this soon.

(Note to myself: Enable "strict" mode)

@Baune8D
Copy link
Contributor Author

Baune8D commented Oct 13, 2022 •
edited

No problem 🙂

FYI exactOptionalPropertyTypes is not included when using strict mode, it's a seperate property: https://www.typescriptlang.org/tsconfig#exactOptionalPropertyTypes

@paescuj paescuj self-requested a review October 13, 2022 15:38
@paescuj paescuj self-assigned this Oct 13, 2022
@gustavohenke gustavohenke merged commit 7c8e644 into open-cli-tools:main Oct 15, 2022
@gustavohenke
Copy link
Member

(Note to myself: Enable "strict" mode)

@paescuj taking care of enabling strict as a starter 🙂

@gustavohenke gustavohenke mentioned this pull request Oct 15, 2022
Merged
@gustavohenke
Copy link
Member

Published in v7.5.0!

renovate bot added a commit to fwouts/previewjs that referenced this pull request Oct 22, 2022
@renovate
chore(deps): update dependency concurrently to ^7.5.0 (#1127)
1ef2cee 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`^7.4.0` ->
`^7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#296
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[open-cli-tools/concurrently#372

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to defenseunicorns/zarf that referenced this pull request Oct 22, 2022
@renovate
Update dependency concurrently to v7.5.0 (#937)
5e352b2 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.4.0` ->
`7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#296
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[open-cli-tools/concurrently#372

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Noxsios pushed a commit to defenseunicorns/zarf that referenced this pull request Mar 8, 2023
@renovate
Update dependency concurrently to v7.5.0 (#937)
55f58e8 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.4.0` ->
`7.5.0`](https://renovatebot.com/diffs/npm/concurrently/7.4.0/7.5.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/compatibility-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.5.0/confidence-slim/7.4.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.5.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.5.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.4.0...v7.5.0)

#### What's Changed

- Add auto colors functionality by
[@&#8203;eliasm307](https://togithub.com/eliasm307),
[@&#8203;paescuj](https://togithub.com/paescuj),
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#296
- Fix `onFinish` signature when using exactOptionalPropertyTypes by
[@&#8203;Baune8D](https://togithub.com/Baune8D) in
[open-cli-tools/concurrently#372

**Full Changelog**:
open-cli-tools/concurrently@v7.4.0...v7.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuNyIsInVwZGF0ZWRJblZlciI6IjMyLjI0MS43In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

@paescuj paescuj Awaiting requested review from paescuj

Assignees

@paescuj paescuj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Baune8D @coveralls @paescuj @gustavohenke