Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command- syntax capturing for --success #325

Merged
merged 2 commits into from May 22, 2022
Merged

Fix command- syntax capturing for --success #325

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bfb91a
Fix `command-` syntax capturing for `--success`
paescuj May 20, 2022
6a9b035
Relaxing condition for non-match of command-syntax
paescuj May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/completion-listener.ts
View file
Open in desktop
Expand Up @@ -43,15 +43,18 @@ export class CompletionListener {
return events[0].exitCode === 0;
} else if (this.successCondition === 'last') {
return events[events.length - 1].exitCode === 0;
} else if (!/^!?command-.+$/.test(this.successCondition)) {
}

const commandSyntaxMatch = this.successCondition.match(/^!?command-(.+)$/);
if (commandSyntaxMatch === null) {
paescuj marked this conversation as resolved.
Show resolved Hide resolved
// If not a `command-` syntax, then it's an 'all' condition or it's treated as such.
return events.every(({ exitCode }) => exitCode === 0);
}

// Check `command-` syntax condition.
// Note that a command's `name` is not necessarily unique,
// in which case all of them must meet the success condition.
const [, nameOrIndex] = this.successCondition.split('-');
const nameOrIndex = commandSyntaxMatch[1];
const targetCommandsEvents = events.filter(({ command, index }) => (
command.name === nameOrIndex
|| index === Number(nameOrIndex)
Expand Down