Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto colors functionality #296

Merged
merged 12 commits into from Oct 10, 2022
Merged

Add auto colors functionality #296

merged 12 commits into from Oct 10, 2022

Commits on Aug 11, 2022

  1. add auto colors functionality to resolve open-cli-tools#279 

    Co-authored-by: Pascal Jufer <pascal-jufer@bluewin.ch>
    @eliasm307 @paescuj
    eliasm307 and paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    24f1ea8 View commit details
    Browse the repository at this point in the history

  2. update prefix color selector to use a generator

    @eliasm307 @paescuj
    eliasm307 authored and paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    8c29b54 View commit details
    Browse the repository at this point in the history

  3. Remove leftovers from first solution

    @paescuj
    paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    27de589 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @paescuj
    paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f3e6587 View commit details
    Browse the repository at this point in the history

  5. Start comments with upper case 

    To be consistent with existing code style
    @paescuj
    paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2bf1df6 View commit details
    Browse the repository at this point in the history

  6. Consistent use of 'color'

    @paescuj
    paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3376905 View commit details
    Browse the repository at this point in the history

  7. Move assertSelectedColors to expect.extend

    @paescuj
    paescuj committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f3c1fcf View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Revert "Move assertSelectedColors to expect.extend" 

    This reverts commit f3c1fcf.
    @paescuj
    paescuj committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7025f86 View commit details
    Browse the repository at this point in the history

  2. Lint fix (new parens rule)

    @paescuj
    paescuj committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    1a79552 View commit details
    Browse the repository at this point in the history

  3. Enhance & register 'assertSelectedColors' as assert function

    @paescuj
    paescuj committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    59e2c64 View commit details
    Browse the repository at this point in the history

  4. Use 'each' to handle repetive tests and to get rid of 'assertSelected… 

    …Colors'

I'm neither happy with extending expect nor with having expect in a
external function, so I'm using 'it.each' to solve this
    @paescuj
    paescuj committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    fb6bef0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Clarify comment for ACCEPTABLE_CONSOLE_COLORS test

    @paescuj
    paescuj committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7929986 View commit details
    Browse the repository at this point in the history