Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to avoid debounce altogether if unnecessary #52

Closed
wants to merge 1 commit into from

Conversation

lossanarch
Copy link

Even when setting -d 0 the command execution is still debounced enough that filesystem move events do not fire commands correctly (on MacOS 10.13.3) - a move will register an unlink and an add, but only fires the command for the add:
With -c echo {path} {event}:
mv test test1

unlink:test
add:test1
test1 add

This PR fixes the problem by checking if debounce is required at all (based on a non-zero debounce time) and if not required, launches the command with only throttling. This results in what I assume is the correct behaviour:
With -c echo {path} {event}:
mv test test1

unlink:test
add:test1
test unlink
test1 add

I hope this is helpful and many thanks for this project.

@XhmikosR
Copy link
Contributor

Can you rebase this?

@sbleon
Copy link
Contributor

sbleon commented Jul 2, 2020

I think this is effectively resolved in #90, which has been merged. This PR can probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants