Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to React 17 with adjustments to Scrollable #32

Merged
merged 9 commits into from May 4, 2021

Conversation

gaeaehrlich
Copy link
Contributor

Fix for: #7

@ykadosh ykadosh linked an issue May 2, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #32 (f2ec079) into master (2151429) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f2ec079 differs from pull request most recent head 10f05cc. Consider uploading reports for the commit 10f05cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.34%   98.35%   +0.01%     
==========================================
  Files         104      104              
  Lines        2475     2493      +18     
  Branches       34       34              
==========================================
+ Hits         2434     2452      +18     
  Misses         34       34              
  Partials        7        7              
Impacted Files Coverage Δ
src/components/Scrollable/Scrollable.jsx 87.23% <ø> (ø)
src/hooks/useClickOutside/useClickOutside.test.js 100.00% <100.00%> (ø)
src/hooks/useDebounce/useDebounce.js 100.00% <100.00%> (ø)
src/hooks/useDebounce/useDebounce.test.js 100.00% <100.00%> (ø)
src/hooks/useDimensions/useDimensions.test.js 100.00% <100.00%> (ø)
src/hooks/useThrottle/useThrottle.js 100.00% <100.00%> (ø)
src/hooks/useThrottle/useThrottle.test.js 100.00% <100.00%> (ø)
src/tools/ResizeObserver/ResizeObserver.test.js 100.00% <100.00%> (ø)
test/setup.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2151429...10f05cc. Read the comment docs.

@ykadosh ykadosh changed the base branch from master to react-17-upgrade May 4, 2021 12:37
@ykadosh ykadosh merged commit 9dbe7d5 into open-amdocs:react-17-upgrade May 4, 2021
@udia76
Copy link
Collaborator

udia76 commented May 4, 2021

🎉 This PR is included in version 1.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@udia76 udia76 added the released label May 4, 2021
@udia76
Copy link
Collaborator

udia76 commented May 12, 2021

🎉 This PR is included in version 1.3.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollable - Support React 17
3 participants