Update to latest trunk #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ootwch
force-pushed
the
20221105_no_http_host_pr
branch
from
5629e3f
to
7995c19
Compare
…ents. Adds a test to ensure proper processing of directives on special HTML elements, or HTML which contains special elements. These special elements are defined by the HTML API and are the HTML elements which cannot contain other tags, such as the IFRAME, SCRIPT, TEXTAREA, TITLE, elements, etc... The server diretive processor performs a custom tracking of HTML structure and this test ensures it isn't mislead by the handling of those special elements. Developed in #6247 Discussed in https://core.trac.wordpress.org/ticket/60746 Props santosguillamot, cbravobernal, mukesh27, westonruter, swissspidy, dmsnell. Follow-up to [57348]. Fixes #60746. git-svn-id: https://develop.svn.wordpress.org/trunk@57822 602fd350-edb4-49c9-b593-d223f7449a82
Short-circuits directive processing when the markup does not actually contain any `data-wp-*` attributes. This reduces function calls and memory usage for the best case scenario due to not involving `WP_HTML_Tag_Processor`. Props joemcgill, swissspidy, gziolo, cbravobernal, flixos90. Fixes #60749. git-svn-id: https://develop.svn.wordpress.org/trunk@57824 602fd350-edb4-49c9-b593-d223f7449a82
Use a priority of 100 to ensure that other filters can add additional directives before the processing starts. This way, directives will be processed even if the `$parsed_block` variable is edited by a filter. Props cbravobernal, swissspidy, flixos90, joemcgill, gziolo. Fixes #60743. git-svn-id: https://develop.svn.wordpress.org/trunk@57826 602fd350-edb4-49c9-b593-d223f7449a82
This is a follow-up to [57717] to ensure that classic themes without a `theme.json` file or without `appearanceTools: true` in `theme.json` do not have shadow controls by default. Props wildworks, vcanales, madhudollu, swissspidy, youknowriad. Fixes #60633 git-svn-id: https://develop.svn.wordpress.org/trunk@57827 602fd350-edb4-49c9-b593-d223f7449a82
…rs` in PHPCS ruleset. Includes alphabetizing the third party library exclusions section. Follow-up to [50810], [51658], [57524]. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57829 602fd350-edb4-49c9-b593-d223f7449a82
Adds an explicit 1 hour expiration for the translation file cache introduced in [57287] / #58919. This prevents stale caches when a site does not use the regular way of installing language packs, for example when an atomic filesystem is involved. Also configures the `translation_files` group as a global cache group on multisite. Props dd32. Fixes #60764. git-svn-id: https://develop.svn.wordpress.org/trunk@57831 602fd350-edb4-49c9-b593-d223f7449a82
…lings. Resolves an issue where context on a void tag element such as `<img>` was incorrectly passed to following elements. Adds tests. Props santosguillamot, luisherranz, cbravobernal, dmsnell, gziolo, swissspidy. Fixes #60768. git-svn-id: https://develop.svn.wordpress.org/trunk@57832 602fd350-edb4-49c9-b593-d223f7449a82
…php`. Follow-up to [1632], [12507]. Props aristath, poena, afercia, SergeyBiryukov. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57833 602fd350-edb4-49c9-b593-d223f7449a82
… short attribute name. Adds new tests and improves existing ones by using `assertSame` to do type comparison as well. Props jonsurrell, cbravobernal, swissspidy, gziolo. Fixes #60758. git-svn-id: https://develop.svn.wordpress.org/trunk@57835 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up [57563], #60356. Fixes #60757. Props jonsurrell, cbravobernal, swissspidy. git-svn-id: https://develop.svn.wordpress.org/trunk@57836 602fd350-edb4-49c9-b593-d223f7449a82
…ch endpoint. In `WP_REST_Search_Controller`, the `type` parameter is accessed via the sanitization callback for the `subtype` parameter, which is too early for `type` itself to be already sanitized. This change adds a type check in the `get_search_handler()` method to prevent errors when the type doesn’t match. Props swissspidy, timothyblynjacobs, dd32. Fixes #60771. git-svn-id: https://develop.svn.wordpress.org/trunk@57839 602fd350-edb4-49c9-b593-d223f7449a82
…pt module `src`. Ensures parity with the `script_loader_src` filter for regular scripts, allowing the URL to be filtered, for example to load them from a CDN or alter query parameters. Props dd32, peterwilsoncc, westonruter. Fixes #60742. git-svn-id: https://develop.svn.wordpress.org/trunk@57840 602fd350-edb4-49c9-b593-d223f7449a82
This prunes stores and configurations that are empty arrays, as stores are expected to be JSON objects. By not printing empty configurations, less redundant data is serialized into the HTML. Props jonsurrell, luisherranz, darerodz, gziolo, swissspidy. Fixes #60761. git-svn-id: https://develop.svn.wordpress.org/trunk@57841 602fd350-edb4-49c9-b593-d223f7449a82
This aims to bring more consistency with the other `wp_enqueue_style()` calls in the theme's functions. Follow-up to [57311]. Props sabernhardt. Fixes #60779. git-svn-id: https://develop.svn.wordpress.org/trunk@57842 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [57687]. If no icons of the preferred type are available, then the icon array should return the collection of valid icons found, rather than an empty array. Props sabernhardt, swissspidy, sabernhardt, antpb, joedolson. Fixes #60740. git-svn-id: https://develop.svn.wordpress.org/trunk@57845 602fd350-edb4-49c9-b593-d223f7449a82
…e.php`. Follow-up to [20029], [20119], [20144]. Props aristath, poena, afercia, SergeyBiryukov. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57847 602fd350-edb4-49c9-b593-d223f7449a82
…er.php`. Follow-up to [6384], [6456], [6858], [8494], [8961]. Props aristath, poena, afercia, SergeyBiryukov. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57848 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57753] to make tests more robust, as there were multiple permission-related errors in the hosting test results. With this change, the tests now don’t try setting an owner that doesn’t exist. Props peterwilsoncc, costdev, javiercasares. See #57774. git-svn-id: https://develop.svn.wordpress.org/trunk@57849 602fd350-edb4-49c9-b593-d223f7449a82
…comment.php`. Follow-up to [8869], [9207], [23694], [47887]. Props aristath, poena, afercia, SergeyBiryukov. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57850 602fd350-edb4-49c9-b593-d223f7449a82
It includes all the backports from this Gutenberg PR WordPress/gutenberg#59949 Props get_dave, youknowriad. See #60315. git-svn-id: https://develop.svn.wordpress.org/trunk@57851 602fd350-edb4-49c9-b593-d223f7449a82
…leted_post_{$post->post_type}` hooks.
The hooks fire before the general `delete_post` / `deleted_post` hooks and have the same parameters.
They complement the `save_post_{$post->post_type}` hook added in [25050] and the `edit_post_{$post->post_type}` hook added in [43617].
Props benniledl, swissspidy, dargus.
Fixes #60433.
git-svn-id: https://develop.svn.wordpress.org/trunk@57853 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [57793], [57798], [57800], [57801]. Props shailu25. See #60732, #60699. git-svn-id: https://develop.svn.wordpress.org/trunk@57854 602fd350-edb4-49c9-b593-d223f7449a82
…_delete_post()`. This matches the parameter name in `wp_trash_post()` and all the other functions receiving post ID as a parameter. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57857 602fd350-edb4-49c9-b593-d223f7449a82
…ete_post()`. Follow-up to [57853], [57857]. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57858 602fd350-edb4-49c9-b593-d223f7449a82
…late.php`. Follow-up to [3880]. Props aristath, poena, afercia, SergeyBiryukov. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57859 602fd350-edb4-49c9-b593-d223f7449a82
…s_meta(). Props mujuonly. Fixes #60810. See #60700. git-svn-id: https://develop.svn.wordpress.org/trunk@57860 602fd350-edb4-49c9-b593-d223f7449a82
One of the tests for the `wp_kses_xml_named_entities()` function used `utf8_encode( chr( 160 ) )` to set an expectation of a Unicode character for a non-breaking space. It is understandable that this expectation was previously set this way, as it is not possible for a developer to distinguish between a ''breaking'' space and a ''non-breaking'' space visually, so the chances of the test accidentally breaking on an incorrect save when the plain Unicode character would be used, was high. However, the `utf8_encode()` function is deprecated as of PHP 8.2, and its use needs to be removed from the WP codebase. PHP 7.0 has introduced [https://wiki.php.net/rfc/unicode_escape Unicode escape sequences], which allows to create a text string using Unicode characters referenced by their codepoint. By switching the test case to provide the test expectation using a Unicode escape sequence, we remove the use of the deprecated PHP function and still preserve the safeguard against the test accidentally breaking. Follow-up to [52229]. Props jrf, afercia, poena, SergeyBiryukov. See #55603, #60705. git-svn-id: https://develop.svn.wordpress.org/trunk@57861 602fd350-edb4-49c9-b593-d223f7449a82
This changeset updates a translation string to ensure the "Patterns" menu item introduced in [57543] is translatable. This quickfix simply removes the erroneous `context` parameter so no new string is introduced during WP 6.5 string freeze period. A follow-up changeset will be needed to replace the current `__()` function with `_x()` and put back the `context` parameter. Follow-up to [57543]. Props jdy68, audrasjb, kebbet, swissspidy. Fixes #60825. git-svn-id: https://develop.svn.wordpress.org/trunk@57864 602fd350-edb4-49c9-b593-d223f7449a82
…ibrary. Prevents an error when uploading fonts on certain systems, because the `mbstring` extension can be missing and thus the function may not be available. Props mujuonly, swissspidy, peterwilsoncc. Fixes #60823. See #55603. git-svn-id: https://develop.svn.wordpress.org/trunk@57865 602fd350-edb4-49c9-b593-d223f7449a82
Add `aria-hidden="true"` to the dashicon symbol used as the `close` icon in Thickbox modals. Prevent the icon from being read as a replacement character by screen readers. Props stevejonesdev, sabernhardt, joedolson. See #61028. git-svn-id: https://develop.svn.wordpress.org/trunk@58167 602fd350-edb4-49c9-b593-d223f7449a82
…es()`. `shortcode_parse_atts()` always returns an array as of [57597], so the check is no longer needed. Follow-up to [40070], [57597]. Props david.binda, swissspidy, oglekler. Fixes #60581. git-svn-id: https://develop.svn.wordpress.org/trunk@58168 602fd350-edb4-49c9-b593-d223f7449a82
This caused issues in maintenance mode, and it's not warranted to have its own module. This will live alongside `_canonical_charset()`, it's partner function. Fixes: #61182. Props: dmsnell, sergeybiryukov, swisspiddy. Follow-up to: [58148]. git-svn-id: https://develop.svn.wordpress.org/trunk@58169 602fd350-edb4-49c9-b593-d223f7449a82
Adds support for setting spans using `grid-column` and `grid-row` properties on children of blocks with grid layout. Props isabel_brison, andrewserong, peterwilsoncc, mukesh27. Fixes #61111. git-svn-id: https://develop.svn.wordpress.org/trunk@58170 602fd350-edb4-49c9-b593-d223f7449a82
…hy_font_size_value`. Updates `wp_get_typography_font_size_value` to accept an array of theme.json settings instead of a boolean derived from global state. Props ramonopoly, audrasjb. Fixes #61118. git-svn-id: https://develop.svn.wordpress.org/trunk@58171 602fd350-edb4-49c9-b593-d223f7449a82
…cated. Any usage of `'who' => 'authors'` should be updated to use capability queries instead. Includes documenting the capability query parameters in `wp_dropdown_users()`. Follow-up to [51943]. Props kkmuffme, swissspidy, SergeyBiryukov. See #61243. git-svn-id: https://develop.svn.wordpress.org/trunk@58172 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a unit test to assert that CSS variables are defined in `:root{}` rather than `body{}`. Fixes a couple of docblocks in the same file.
Follow up to [58171].
Props ramonopoly.
See #61118.
git-svn-id: https://develop.svn.wordpress.org/trunk@58173 602fd350-edb4-49c9-b593-d223f7449a82
…to-draft posts. The post editor uses the permalink_template property from the posts REST API to render the post slug input or not. For auto-drafts or newly created posts, this property was not set properly. This PR solves by fixing the get_sample_permalink function used to compute this property. Props youknowriad, mcsf, antonvlasenko, azaozz, peterwilsoncc, andrewserong, hellofromTonya, spacedmonkey. Fixes #59283. git-svn-id: https://develop.svn.wordpress.org/trunk@58174 602fd350-edb4-49c9-b593-d223f7449a82
Expand the comment to further clarify the post object check performed. Follow-up to [58174]. See #59283. git-svn-id: https://develop.svn.wordpress.org/trunk@58175 602fd350-edb4-49c9-b593-d223f7449a82
This resolves a few warnings when running PHPUnit with the code coverage report:
{{{
"@Covers WP_Privacy_Requests_List_Table::get_views" is invalid
"@Covers WP_Block_Bindings_Registry::register_block_bindings_source" is invalid
"@Covers WP_Block_Patterns_Registry::_register_theme_block_patterns" is invalid
}}}
The two removed `@coversDefaultClass` annotations are redundant, as the class name is already included in the individual `@covers` tags. Removing them allows `@covers ::_register_theme_block_patterns` to work as expected, where `_register_theme_block_patterns` is an standalone function, not a class method.
Follow-up to [54215], [56733], [57373], [57562].
See #60705.
git-svn-id: https://develop.svn.wordpress.org/trunk@58176 602fd350-edb4-49c9-b593-d223f7449a82
In the footer the site info and social menu visual order and DOM order was mismatched. This fixes that and resolves the altering. Props afercia, joedolson, rcreators, sabernhardt. Fixes #60496. git-svn-id: https://develop.svn.wordpress.org/trunk@58177 602fd350-edb4-49c9-b593-d223f7449a82
The measurement in px for zero values is not needed. It does this for Twenty Twenty-One, Twenty Ten, Twenty Eleven and Twenty Nineteen. This also adds short-hand-property-no-redudant-values to Twenty Twenty-One's stylelint rules. Included is removing box-shadow prefixed rules before the standard property in Twenty Ten. Finally, it also removes empty spaces at the ends of lines in Twenty Thirteen, Twenty Nineteen and Twenty Twenty. Props ankitmaru, SergeyBiryukov, netweb, mukesh27, ryelle, audrasjb, sabernhardt. Fixes #53874. git-svn-id: https://develop.svn.wordpress.org/trunk@58178 602fd350-edb4-49c9-b593-d223f7449a82
The screenshot wasn't showing the front view. This now resolves it to fit guidelines. Props kafleg, poena, shivashankerbhatta, SergeyBiryukov. Fixes #56949. git-svn-id: https://develop.svn.wordpress.org/trunk@58179 602fd350-edb4-49c9-b593-d223f7449a82
Add more context to the `split_the_query` filter by adding two new parameters: '$old_request' and '$clauses'. This enriches the filter with additional information about the SQL query before the query is run, enabling developers to have more context to help decide if a query should be split. Props spacedmonkey, shailu25, rcorrales, tillkruess. Fixes #59514. git-svn-id: https://develop.svn.wordpress.org/trunk@58180 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Includes renaming a few test classes per the naming conventions. Reference: [https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization Writing PHP Tests: Naming and Organization]. Follow-up to [53076], [53085], [54497], [56046], [56614], [57246], [57491]. See #60705. git-svn-id: https://develop.svn.wordpress.org/trunk@58181 602fd350-edb4-49c9-b593-d223f7449a82
…d multiple network options with a single database request. WordPress's `get_network_option` function generally makes individual database requests for each network option. While some options are preloaded in `wp_load_core_site_options`, many still require single database calls to the network options table. Building on the work done in [56445], [56990], and [57013], which introduced the `wp_prime_option_caches` function, this commit adds two new functions: `wp_prime_network_option_caches` and `wp_prime_site_option_caches`. These functions enable developers to pass an array of option names, allowing caches for these options to be primed in a single object cache or database request. If an option is not found, the notoptions cache key is refreshed, preventing unnecessary repeated requests. The function `wp_prime_site_option_caches` is similar to `get_site_option`, enabling developers to retrieve network options on the current network without needing to know the current network ID. If these functions are called in a non-multisite environment, they fall back to using wp_prime_option_caches. These functions have been implemented in `wp_load_core_site_options`, `get_site_transient`, and `set_site_transient`. Props to spacedmonkey, peterwilsoncc, mukesh27, joemcgill. Fixes #61053. git-svn-id: https://develop.svn.wordpress.org/trunk@58182 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that not only the return values match the expected results, but also that their type is the same. Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable. Follow-up to [56052]. See #60705. git-svn-id: https://develop.svn.wordpress.org/trunk@58183 602fd350-edb4-49c9-b593-d223f7449a82
The purpose is to enable using the excerpt as a description for user-created patterns on the Site Editor Pattern screens. This commit backports the original PR from Gutenberg repository: * [[WordPress/gutenberg#60549: [Data Views] User patterns: Use excerpt as description]] Reference: [[WordPress/gutenberg#55244: Patterns: Add descriptions to user-created patterns]]. Follow-up to [44146], [44150], [50835], [56030]. Props poena, ntsekouras, krupalpanchal. Fixes #61250. git-svn-id: https://develop.svn.wordpress.org/trunk@58184 602fd350-edb4-49c9-b593-d223f7449a82
This improves performance of the `WP_Theme_JSON_Resolver` class by avoiding redundant construction of `WP_Theme_JSON` objects for each origin. Props thekt12, joemcgill, swissspidy, audrasjb, oandregal. Fixes #61112. git-svn-id: https://develop.svn.wordpress.org/trunk@58185 602fd350-edb4-49c9-b593-d223f7449a82
The Block Hooks UI relies on the `ignoredHookedBlocks` metadata when determining whether to show the toggle in the Site Editor. The problem is that for uncustomized templates we don't add this metadata. Currently the visitor functions have a default callback of `insert_hooked_blocks` and we only add the metadata when we're writing to the database via an available filter in the template controller. This changeset creates a new callback which both inserts the hooked blocks and adds the `ignoredHookedBlocks` metadata to the anchor block, and uses this new callback explicitly in the visitor functions that are run upon reading from the database. We continue to set the `ignoredHookedBlocks` metadata when writing to the database, i.e. this operation happens twice. Although not ideal, this is necessary to cover the following scenarios: * When the user adds an anchor block within the editor, we still need to add the `ignoredHookedBlocks` meta to it to prevent hooked blocks hooking on to it unexpectedly on the frontend. This is required to keep parity between the frontend and editor. * When a user writes template data to the database directly through the API (instead of the editor), we need to again ensure we're not inserting hooked blocks unexpectedly. It is worth noting that with this change, the first hooked block to insert relative to its anchor block will be accepted. Any additional blocks of the same type (e.g. a second `core/loginout` block) trying to hook onto the same anchor block will be ignored, irrespective of the position. Props tomjcafferkey, bernhard-reiter, gziolo. Fixes #59574. git-svn-id: https://develop.svn.wordpress.org/trunk@58186 602fd350-edb4-49c9-b593-d223f7449a82
Updates the editor npm packages to latest versions. See #6612. Props ellatrix, mukesh27, youknowriad, mamaduka. git-svn-id: https://develop.svn.wordpress.org/trunk@58187 602fd350-edb4-49c9-b593-d223f7449a82
This patch introduces a new class: `WP_Token_Map`, designed for efficient lookup and translation of static mappings between string keys or tokens, and string replacements (for example, HTML character references). The Token Map imposes certain restrictions on the byte length of the lookup tokens and their replacements, but is a highly-optimized data structure for mappings with a very high number of tokens. Developed in #5373 Discussed in https://core.trac.wordpress.org/ticket/60698 Fixes #60698. Props: dmsnell, gziolo, jonsurrell, jorbin. git-svn-id: https://develop.svn.wordpress.org/trunk@58188 602fd350-edb4-49c9-b593-d223f7449a82
This was forgotten in changeset 58187. git-svn-id: https://develop.svn.wordpress.org/trunk@58189 602fd350-edb4-49c9-b593-d223f7449a82
Previously the HTML Process was ignoring the `class_name` argument in the `next_tag()` query if it existed. This was wrong and would lead to calling code finding the wrong tag if provided. This patch adds the class detection code back into `next_tag()` to fix the bug. Developed in #6618 Discussed in https://core.trac.wordpress.org/ticket/58517 See #58517. Follow-up to [56274]. Props: dmsnell, jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58190 602fd350-edb4-49c9-b593-d223f7449a82
The HTML Processor maintains a stack of open elements, where every element, every `#text` node, every HTML comment, and other node is pushed and popped while traversing the document. The "depth" of each of these nodes represents how deep that stack is where the node appears. Unfortunately this information isn't exposed to calling code, which has led different projects to attempt to calculate this value externally. This isn't always trivial, but the HTML Processor could make it so by exposing the internal knowledge in a new method. In this patch the `get_current_depth()` method returns just that. Since the processor always exists within a context, the depth includes nesting from the always-present html element and also the body, since currently the HTML Processor only supports parsing in the IN BODY context. This means that the depth reported for the `DIV` in `<div>` is 3, not 1, because its breadcrumbs path is `HTML > BODY > DIV`. Developed in #6589 Discussed in https://core.trac.wordpress.org/ticket/61255 Fixes #61255. Props dmsnell, jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58191 602fd350-edb4-49c9-b593-d223f7449a82
This patch adds a new method, `WP_HTML_Processor->expects_closer()` to indicate if the currently-matched node expects to find a closing token. For example, a `DIV` element expects a closing `</div>` tag, but an `<img>` expects none, because it's a void element. Similarly, `#text` nodes and HTML comments only appear as unitary nodes on the stack of open elements. Once proceeding further in the document they are immediately removed without any closing tag. This new method serves as a helper to indicate whether or not to expect the closer, as this can be more complicated than it seems, and calling code shouldn't have to build custom interpretations and implementations. Instead, the HTML Processor ought to export its internal knowledge to make it easy for consuming code and projects. Developed in #6600 Discussed in https://core.trac.wordpress.org/ticket/61257 Fixes #61257. Props dmsnell, jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58192 602fd350-edb4-49c9-b593-d223f7449a82
This updates the build to account for related changes in WordPress packages. More details in WordPress/gutenberg#61486. Props jonsurrell, youknowriad, swissspidy, gziolo. Fixes #61262. git-svn-id: https://develop.svn.wordpress.org/trunk@58193 602fd350-edb4-49c9-b593-d223f7449a82
Props peterwilsoncc. Fixes #61111. git-svn-id: https://develop.svn.wordpress.org/trunk@58194 602fd350-edb4-49c9-b593-d223f7449a82
Syncs the changes from Gutenberg: WordPress/gutenberg#60514. Enqueues a different Interactivity API runtime version with preact/debug when SCRIPT_DEBUG is enabled. Props darerodz, jonsurrell, gziolo. Fixes #61171. git-svn-id: https://develop.svn.wordpress.org/trunk@58195 602fd350-edb4-49c9-b593-d223f7449a82
…in WP 6.6. Follow-up to [58170]. See #61111. git-svn-id: https://develop.svn.wordpress.org/trunk@58196 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest trunk