Feature/typescript #239
Open
Feature/typescript #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for gatsby-src-instagram pending review.Visit the deploys page to approve it
|
|
I tested this on my site and it works as expected @oorestisime |
oorestisime
reviewed
Nov 7, 2022
README.md
Outdated
| @@ -56,29 +52,6 @@ plugins: [ | |||
| }, | |||
| ] | |||
| ``` | |||
|
|
|||
| ### Public scraping for a user's profile | |||
There was a problem hiding this comment.
can we keep those deprecated for reference please? i dont have any other docs page :D
| @@ -23,7 +27,11 @@ | |||
| "eslint-plugin-jsx-a11y": "6.3.1", | |||
| "eslint-plugin-prettier": "3.1.4", | |||
| "eslint-plugin-react": "7.20.6", | |||
| "prettier": "2.1.2" | |||
| "gatsby": "^4.24.7", | |||
There was a problem hiding this comment.
Yea we probably just need it as a peer dependency.
DDeme
approved these changes
Nov 13, 2022
graysonhicks
force-pushed
the
feature/typescript
branch
from
95e0e63
to
754247b
Compare
rewrite in typescript start fixed all types but one tsc build command and fix map deprecated apis and peerdeps
graysonhicks
force-pushed
the
feature/typescript
branch
from
754247b
to
1cafa96
Compare
|
Okay, sorry for the delay. Rebased this and added the deprecation notes back. Tested again on my site and works as expected. I noticed in the example dir, there may be an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR to fix #207
Draft PR reliant on #238 first.
Adds TS and types with corresponding clean-up.