-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/typescript #239
base: master
Are you sure you want to change the base?
Feature/typescript #239
Conversation
👷 Deploy request for gatsby-src-instagram pending review.Visit the deploys page to approve it
|
I tested this on my site and it works as expected @oorestisime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rebase please? Also left some comments
README.md
Outdated
@@ -56,29 +52,6 @@ plugins: [ | |||
}, | |||
] | |||
``` | |||
|
|||
### Public scraping for a user's profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep those deprecated for reference please? i dont have any other docs page :D
@@ -23,7 +27,11 @@ | |||
"eslint-plugin-jsx-a11y": "6.3.1", | |||
"eslint-plugin-prettier": "3.1.4", | |||
"eslint-plugin-react": "7.20.6", | |||
"prettier": "2.1.2" | |||
"gatsby": "^4.24.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about gatsby 5 compat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea we probably just need it as a peer dependency.
95e0e63
to
754247b
Compare
rewrite in typescript start fixed all types but one tsc build command and fix map deprecated apis and peerdeps
754247b
to
1cafa96
Compare
Okay, sorry for the delay. Rebased this and added the deprecation notes back. Tested again on my site and works as expected. I noticed in the example dir, there may be an issue with |
DRAFT PR to fix #207
Draft PR reliant on #238 first.
Adds TS and types with corresponding clean-up.