mperham#113 PR comment: rename #pool to #wrapped_pool

Changes.md

@@ -6,7 +6,7 @@ HEAD
 
 - Use monotonic clock present in all modern Rubies [Tero Tasanen, #109]
 - Remove code hacks necessary for JRuby 1.7
-- Expose `pool` from ConnectionPool::Wrapper [Thomas Lecavelier, #113]
+- Expose wrapped pool from ConnectionPool::Wrapper [Thomas Lecavelier, #113]
 
 2.2.2
 ------

lib/connection_pool.rb

@@ -109,13 +109,13 @@ def available
   private
 
   class Wrapper < ::BasicObject
-    METHODS = [:with, :pool_shutdown, :pool]
+    METHODS = [:with, :pool_shutdown, :wrapped_pool]
 
     def initialize(options = {}, &block)
       @pool = options.fetch(:pool) { ::ConnectionPool.new(options, &block) }
     end
 
-    def pool
+    def wrapped_pool
       @pool
     end
 

test/test_connection_pool.rb

@@ -474,9 +474,9 @@ def test_shutdown_is_executed_for_all_connections_in_wrapped_pool
     assert_equal [["shutdown"]] * 3, recorders.map { |r| r.calls }
   end
 
-  def test_wrapper_pool
+  def test_wrapper_wrapped_pool
     wrapper = ConnectionPool::Wrapper.new { NetworkConnection.new }
-    assert_equal ConnectionPool, wrapper.pool.class
+    assert_equal ConnectionPool, wrapper.wrapped_pool.class
   end
 
   def test_wrapper_method_missing