-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing colors not using theme colors and renaming some css variables #421
Open
jovica-me
wants to merge
15
commits into
onwidget:main
Choose a base branch
from
jovica-me:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed all the types and references - removed class text-page
Hi @jovica-me We are working on a new definition of tokens. We prefer not to mix this PR for now (lots of changes) until we study well the needs and variants we have to achieve greater flexibility in a clean way. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We previously discussed about colors and the design system is in the theme. I didn't want to make a pull request with big changes so this pull request is only focuses on using the exiting token and fully utilizing them in the code. You can see changes to each specific token in the commits.
Some of the changes:
tertiary
button the unused button one and renamingsecondary
tooutline
because it was never using the secondary color.There are some places where I didn't make any changes like
Pricing.astro
because they can require marking new tokens outside the exiting ones.