Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gexec: allow more headroom for SIGABRT-related unit tests #581

Merged
merged 1 commit into from Aug 29, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions gexec/session_test.go
Expand Up @@ -130,7 +130,7 @@ var _ = Describe("Session", func() {
Expect(err).ShouldNot(HaveOccurred())

session.Signal(syscall.SIGABRT)
Eventually(session).Should(Exit(128 + 6))
Eventually(session).WithTimeout(5 * time.Second).Should(Exit(128 + 6))
})

It("should ignore sending a signal if the command did not start", func() {
Expand Down Expand Up @@ -251,9 +251,9 @@ var _ = Describe("Session", func() {

Signal(syscall.SIGABRT)

Eventually(session1).Should(Exit(128 + 6))
Eventually(session2).Should(Exit(128 + 6))
Eventually(session3).Should(Exit(128 + 6))
Eventually(session1).WithTimeout(5 * time.Second).Should(Exit(128 + 6))
Eventually(session2).WithTimeout(5 * time.Second).Should(Exit(128 + 6))
Eventually(session3).WithTimeout(5 * time.Second).Should(Exit(128 + 6))
})
})

Expand Down