Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max number of samples in experiments on non-64-bit systems. #528

Merged
merged 1 commit into from Mar 25, 2022
Merged

Fix max number of samples in experiments on non-64-bit systems. #528

merged 1 commit into from Mar 25, 2022

Commits on Mar 25, 2022

  1. Fix max number of samples in experiments on non-64-bit systems. 

    The use of `math.MaxInt64` as the maximum number of samples in the context
of general int variables can lead to inconsistent behavior on non-64-bit
systems.

This patch addresses this by using `math.MaxInt32` as the default sample
size in case an explicit one is not provided in the `SamplingConfig`.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
    @aznashwan
    aznashwan committed Mar 25, 2022
    Copy the full SHA
    c2b3449 View commit details
    Browse the repository at this point in the history