470: Use google.golang.org/protobuf/proto #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to google.golang.org/protobuf/proto This ipdates the imports This is a huge leap and it comes with some necessary changes simple_message.proto includes go_package option now. and the message equality of two protobuf messages should be checked by proto.Equal. Update yaml to v3 and golang/x/net to the next version
|
@onsi I'm interested in seeing this PR being merged in, but I see that it is suffering from merge conflicts and I'm not sure if the author is around to fix them, so would you be open to a new PR? |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message: Update to google.golang.org/protobuf/proto
This ipdates the imports
This is a huge leap and it comes with some necessary changes
simple_message.proto includes go_package option now.
and the message equality of two protobuf messages should be checked by proto.Equal.
Update yaml to v3 and golang/x/net to the next version
Fixes #470