implements new gleak goroutine leak detection experimental package #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thediveo
commented
Apr 4, 2022
•
thediveo
commented
- implements issue Feature: goroutine leak testing #536; the code and documentation is under Gomega's license.
- provides goroutine discovery as goroutine.Goroutine
- provides HaveLeaked matcher for reasoning on slices of goroutines for leak detection
- provides set of IgnoringXXX matchers for identifying good (non-leaky) goroutines
- provides unit tests for gleak and gleak/goroutine packages
- updates documentation and adds Gleakiee, the leaky gopher, mascot
- provides goroutine discovery as goroutine.Goroutine - provides HaveLeaked matcher for reasoning on slices of goroutines for leak detection - provides set of IgnoringXXX matchers for identifying good (non-leaky) goroutines - provides unit tests for gleak and gleak/goroutine packages - updates documentation and adds Gleakiee, the leaky gopher, mascot
onsi
reviewed
Apr 8, 2022
| @@ -2951,4 +2951,292 @@ Describe("server performance", func() { | |||
| }) | |||
| ``` | |||
|
|
|||
| ## `gleak`: Finding Leaked Goroutines | |||
There was a problem hiding this comment.
These docs are fantastic ! Thanks for taking the time to write them up!
|
hey @thediveo this looks fantastic! It looks good to merge to me! Was there anything else you wanted to add/consider before we pull the trigger? |
|
No. (Except to duck down, maybe) The irony of it is that now I'm finding goroutine leaks in my tests, but the production code seems to be fine. I'm wondering if we should come up next with a file descriptor leak tester, albeit I only know how to do this on Linux thanks to its |
|
oh man file descriptor leaks are the worst. This all looks great, gonna merge it in now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.