Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reporters/junit: Use system-out element instead of passed #769

Merged
merged 1 commit into from Feb 10, 2021
Merged

reporters/junit: Use system-out element instead of passed #769

merged 1 commit into from Feb 10, 2021

Commits on Feb 10, 2021

  1. reporters/junit: Use system-out element instead of passed 

    In onsi#586, the JUnit reporter was extended to capture the output of passing tests
when the -reportPassing flag is used.

However, the passed element is not in the JUnit XML schema. While that alone
might a theoretical problem, it is also a practical problem, because some
parsers, e.g., the TeamCity XML Reporting Plugin JUnit parser, conform to that
schema, ignore the element, and show no output for passing tests.

The fix seems to be to use the system-out element instead. I have confirmed
that, when using the system-out attribute, the TeamCity XML Reporting Plugin
Junit parser shows output for a passing test.
    @dlipovetsky
    dlipovetsky committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6530676 View commit details
    Browse the repository at this point in the history