Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on github.com/hpcloud/tail #627

Closed
wants to merge 6 commits into from

Conversation

mohammed90
Copy link

@mohammed90 mohammed90 commented Nov 19, 2019

Updates #622 and adds Windows support as positive side-effect

@mohammed90 mohammed90 changed the title remove dependency on github.com/hpcloud/tail by using io.TeeReader (WIP) remove dependency on github.com/hpcloud/tail by using io.TeeReader Nov 19, 2019
@mohammed90 mohammed90 changed the title (WIP) remove dependency on github.com/hpcloud/tail by using io.TeeReader (WIP) remove dependency on github.com/hpcloud/tail Nov 21, 2019
@mohammed90
Copy link
Author

Okay, I'm at loss now. The failures recur despite the code is almost exactly as it were, except for the streaming part and a few additional OS-specific files. Different Go versions have different results, though Go 1.12.x and Go tip have matching results. Those particular tests don't seem to be run for other PRs and master, which is odd given that the test suit doesn't seem to have changed lately (unless I'm mis-seeing).

Successfully removing github.com/hpcloud/tail makes the this package usable on Dragonfly and Illumos. I've addressed the limitation for Plan9. Nacl is a different story.

@mohammed90 mohammed90 changed the title (WIP) remove dependency on github.com/hpcloud/tail remove dependency on github.com/hpcloud/tail Nov 23, 2019
@blgm
Copy link
Collaborator

blgm commented May 28, 2020

#667 has replaced the github.com/hpcloud/tail package with another one. I'm wondering whether it's worth keeping this PR, or whether #667 has solved the underlying problem.

@mohammed90
Copy link
Author

I guess it isn't needed anymore.

@mohammed90 mohammed90 closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants