Color aliases for custom color support #1101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1095 introduced custom color support. This PR improves the implementation, so that it doesn't rely on entering entire escape codes but instead it uses the color names and for the 256 color palette it uses their number.
Example of how this feature improves usablity when using a color scheme like solarized. Before this change the colors looks like this when using the solarized color scheme
By setting the following envvars
The output now looks like this
One could also chose to use the color numbers like (which also is needed to reference the 256 color palette).
This moves the custom color support away from the raw ASCI escapes and instead uses words for the standard 16 terminal colors or optionally 0-255 for the extended 256 color palette.
Besides the feature improvement a missing envvar unset in the tests was added.
fixes #1098